The Bible uses a "God is . . .[a noun]" expression in one of at least five or six ways.
For the LORD thy God is a consuming fire, even a jealous God.
(Deuteronomy 4:24, KJV; c.f. Hebrews 12:29)
Hear, O Israel: The LORD our God is one LORD: (Deuteronomy 6:4,
KJV; c.f. Galatians 3:20)
For the LORD God is a sun and shield: the LORD will give grace and
glory: no good thing will he withhold from them that walk uprightly.
(Psalm 84:11, KJV)
God is a Spirit: and they that worship him must worship him in spirit and in truth. (John 4:24, KJV)
This then is the message which we have heard of him, and declare unto
you, that God is light, and in him is no darkness at all. (1 John
1:5, KJV)
He that loveth not knoweth not God; for God is love. (1 John 4:8,
KJV)
Of these verses, only the "God is one" is grammatically uncertain as to being a noun [it depends on the Hebrew interpretation, as a number can be a noun or an adjective], and if we were to add titles, we could include statements like "God is the King" (Psalm 47:7). But limiting ourselves to matters of substance, the verses outlined above are fairly comprehensive.
God is . . .
- fire
- light
- love
- [one]
- spirit
- sun and shield
While the concepts of "fire", "light", and "sun and shield" may be more nearly related to each other, they seem to contrast with "love", "spirit", and "one." Clearly, it would be inappropriate to pin God down to any one of these equations to the exclusion of the others. Therefore, one might choose to consider each aspect as true in its own right, yet not fully descriptive of God, nor all-encompassing. If one chooses to accept each on the basis of its metaphorical value, it must still not negate the possibility of having a literal application.
Light, for example, might represent truth. But when people came nearest to seeing God, the brightness was always so intense as cause them to cover their faces, and/or be blinded by it (consider Paul's loss of sight on his journey to Damascus).
And it came to pass, that, as I made my journey, and was come nigh
unto Damascus about noon, suddenly there shone from heaven a great
light round about me. (Acts 22:6, KJV)
Notably, this "great light" is contrasted with the light of noonday. This light, then, is more than metaphor. In fact, Revelation informs us that in the earth made new, we will have no need of the light of the sun, because . . .
And there shall be no night there; and they need no candle, neither
light of the sun; for the Lord God giveth them light: and they
shall reign for ever and ever. (Revelation 22:5, KJV)
Again, this seems more than metaphor; though it could certainly intend a dual meaning--both symbolic and literal.
The metaphorical value of light is that light represents truth. This contrasts with darkness being akin to ignorance and error. But God is a being, and He is more than mere truth.
Conclusion
Yes, 1 John 1:5 may have a symbolic or metaphorical meaning, but it almost certainly means more than this. Throughout the Bible, God is depicted as being light: light is one of His attributes.